From 603446111a68d828d67b1e308e2bf7c7afb044ce Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Sat, 11 Feb 2023 01:30:54 +0100 Subject: [PATCH] fail hard + info --- server/certificates/acme_config.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/certificates/acme_config.go b/server/certificates/acme_config.go index 721fda8..69568e6 100644 --- a/server/certificates/acme_config.go +++ b/server/certificates/acme_config.go @@ -5,6 +5,7 @@ import ( "crypto/elliptic" "crypto/rand" "encoding/json" + "fmt" "os" "github.com/go-acme/lego/v4/certcrypto" @@ -33,8 +34,8 @@ func setupAcmeConfig(configFile, acmeAPI, acmeMail, acmeEabHmac, acmeEabKID stri // Validate Config _, err := lego.NewClient(myAcmeConfig) if err != nil { - // TODO: should we fail hard instead? - log.Error().Err(err).Msg("Can't create ACME client, continuing with mock certs only") + log.Info().Err(err).Msg("config validation failed, you might just delete the config file and let it recreate") + return nil, fmt.Errorf("acme config validation failed: %w", err) } return myAcmeConfig, nil } else if !os.IsNotExist(err) {